This repository was archived by the owner on Jun 13, 2025. It is now read-only.
feat: Receive user name for new Terms of Service UI #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvin-codecov
force-pushed
the
cy/accept_name_tos
branch
from
2a07b3a to
adea2a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
=======================================
Coverage 96.09% 96.10%
=======================================
Files 835 835
Lines 19556 19576 +20
=======================================
+ Hits 18793 18813 +20
Misses 763 763
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JerrySentry
reviewed
Jan 15, 2025
codecov_auth/commands/owner/interactors/save_terms_agreement.py
Outdated
Show resolved
Hide resolved
JerrySentry
reviewed
Jan 15, 2025
JerrySentry
reviewed
Jan 15, 2025
calvin-codecov
force-pushed
the
cy/accept_name_tos
branch
from
f322a0d to
f28e35c
Compare
calvin-codecov
force-pushed
the
cy/accept_name_tos
branch
from
f28e35c to
dbaad07
Compare
calvin-codecov
force-pushed
the
cy/accept_name_tos
branch
from
ace77db to
d045615
Compare
calvin-codecov
changed the title
JerrySentry
approved these changes
Jan 17, 2025
calvin-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
calvin-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
New onboarding changes for pre-PAT appless to make it easier and more clear for users to sign up. We are changing up the required information that a user must fill out to complete onboarding. We will no longer be asking for customer intent and for the user to select a default organization in step that follows this screen.
Links to relevant tickets
codecov/engineering-team#3174
Changes related to the UI changes designated in this Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=sMCRUMT3J1bwIct1-1
What does this PR do?
For the onboarding page, we are:
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.